Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcd error to match correct url #5909

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Jul 27, 2022

Signed-off-by: Derek Nola [email protected]

Proposed Changes

Old output:

Found [thisnode1=http://10.10.10.123:2380], expect: thisnode1=10.10.10.123 

New output:

Found [thisnode1=http://10.10.10.123:2380], expect: thisnode1=https://10.10.10.123:2380 

Types of Changes

Verification

Difficult to reproduce, seen during a customer escalation
Bring up an HA config.
Purposely mangle the peerurl via etcdctl member update <MEMBER_ID> --peer-url= with an incorrect IP or a http: not https:.
See the error message.

Testing

Linked Issues

#5915

User-Facing Change

The etcd error on incorrect peer urls now correctly includes the expected https and 2380 port.

Further Comments

@dereknola dereknola marked this pull request as ready for review July 28, 2022 15:23
@dereknola dereknola requested a review from a team as a code owner July 28, 2022 15:23
@dereknola dereknola merged commit 4c0bc8c into k3s-io:master Jul 29, 2022
@dereknola dereknola deleted the etcd_member_error branch August 1, 2022 18:35
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 3, 2022
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 3, 2022
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 3, 2022
dereknola added a commit to dereknola/k3s that referenced this pull request Aug 3, 2022
nikolaishields pushed a commit to nikolaishields/k3s that referenced this pull request Sep 14, 2022
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Nikolai Shields <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants